Allow user specified granularity in relative time ranges #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| calendar = DateUtils.truncate(calendar, Calendar.MONTH); | ||
| } else if ("week".equals(unit)) { | ||
| calendar.set(Calendar.DAY_OF_WEEK, Calendar.SUNDAY); | ||
| calendar = DateUtils.truncate(calendar, Calendar.DAY_OF_MONTH); |
There was a problem hiding this comment.
shudnt this be DAY_OF_WEEK?
There was a problem hiding this comment.
No, that gives an error. That's why first I am rounding to start of week, and then using truncate to get rid of hours, minutes etc.
|
Does TestCubeRewriter.testQueryWithNow need change? Otherwise code changes look good. |
|
TestCubeRewriter.testQueryWithNow doesn't have to be changed since it is checking that candidate tables are not available. All tests in TestCubeRewriter are passing. I am running tests on the entire cube.* package, will update pull request in case of any failures. |
|
Tests passing. |
ghost
pushed a commit
that referenced
this pull request
Sep 23, 2014
Allow user specified granularity in relative time ranges
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.