Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Tag Filter #1714

Open
jeyjai opened this issue Jul 11, 2024 · 3 comments
Open

GitHub Tag Filter #1714

jeyjai opened this issue Jul 11, 2024 · 3 comments
Labels
enhancement New feature or request source-specific This bug/feature affects a specific source

Comments

@jeyjai
Copy link

jeyjai commented Jul 11, 2024

Describe the bug
If i try to typing an older version in the "Version String Extraction RegEx" field it instantly tells me "could not determine release version", and this is on any app i try it on.
I'm pretty sure I've used it before and it was working, so I'm not sure what I'm doing wrong now or if it's w bug.

To Reproduce
Steps to reproduce the behavior:

  1. Go to literally any app you've got added, let's pick obtainium as an example.
  2. Tap the "additional optyions" button
  3. Scroll down to "version string extraction"
  4. Type the previous version, 1.1.12 in this case for obtainium, and tap continue
  5. See error "could not determine release version".

Screenshots and Logs
Screenshot_20240711_181020

Please complete the following information:

  • Device: Samsung Galaxy A52s
  • OS: Android 14
  • Obtainium Version: v1.1.13

Additional context

@jeyjai jeyjai added bug Something isn't working to check Issue has not been reviewed labels Jul 11, 2024
@ImranR98
Copy link
Owner

"Version string extraction" should be renamed to "Trim version string" since that's what it does - it takes the version string and removes part of it. That's useful for when the developer adds extra info to their GitHub tag that you don't want (since the "version" is really just the GitHub tag). The only source with actual version string extraction from a link is the HTML source.

Sounds like what you're looking for is the release title filter.

@jeyjai
Copy link
Author

jeyjai commented Jul 14, 2024

@ImranR98 ok so i had misunderstood its use. Is there any way to input a specific version you want to download and have obtainium find it?
The version isn't always included in the release notes or release titles, but it's almost always included in the tags

@ImranR98
Copy link
Owner

Currently, there isn't.

@ImranR98 ImranR98 reopened this Jul 14, 2024
@ImranR98 ImranR98 changed the title Can't get version string extraction to work GitHub Tag Filter Jul 14, 2024
@ImranR98 ImranR98 added enhancement New feature or request source-specific This bug/feature affects a specific source and removed bug Something isn't working labels Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request source-specific This bug/feature affects a specific source
Projects
None yet
Development

No branches or pull requests

2 participants