Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does anyone maintain it #1045

Open
zhaoyunxing92 opened this issue May 30, 2022 · 3 comments
Open

Does anyone maintain it #1045

zhaoyunxing92 opened this issue May 30, 2022 · 3 comments

Comments

@zhaoyunxing92
Copy link

zhaoyunxing92 commented May 30, 2022

I don't understand why this place is looping instead of one query,It's pointless to sort by looping

L388-L398

private List<Object> findUsingLucene(EntityMetadata m, Client client, Object[] primaryKeys)
    {

xxxxx
        
        for (Object primaryKey : primaryKeys)
        {
            FilterClause filterClause = kunderaQuery.new FilterClause(columnName, equals, primaryKey, idField);
            kunderaQuery.setFilter(kunderaQuery.getEntityAlias() + "." + columnName + " = " + primaryKey);
            queue.clear();
            queue.add(filterClause);
            List<Object> object = findUsingLucene(m, client);
            if (object != null && !object.isEmpty())
                result.add(object.get(0));
        }
        return result;
    }

L205-L221

    protected List findUsingLucene(EntityMetadata m, Client client)
    {
        try
        {
            BasicDBObject orderByClause = getOrderByClause(m);
            // find on id, so no need to add skip() [firstResult hardcoded 0]
            return ((MongoDBClient) client).loadData(m, createMongoQuery(m, getKunderaQuery().getFilterClauseQueue()),
                    null, orderByClause, isSingleResult ? 1 : maxResult, 0, isCountQuery(),
                    getKeys(m, getKunderaQuery().getResult()), getKunderaQuery().getResult());
        }
        catch (Exception e)
        {
            log.error("Error during executing query, Caused by:", e);
            throw new QueryHandlerException(e);
        }

    }
@sailenicolas
Copy link

This project is dead. 4 years with no activity.

@zhaoyunxing92
Copy link
Author

I know this fact bug it's hard to accept

@kuncevic
Copy link

Do we really need ORM over NoSQL? What are the benefits? I am currently looking into utilizing one of this https://github.com/moltar/typescript-runtime-type-benchmarks?tab=readme-ov-file#packages-compared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants