You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In #726@TaranRallings has started calculating stoichiometries for matter flows being supplied to the litter model (they were previously just constants being fed to the litter model). This is all well and good but introduces the edge case where the input has an infinite stoichiometric ratio, i.e. the input is pure carbon. At present, this edge case (which we only rarely expect) causes the entire model to stall.
Describe the solution you'd like
The litter model can amend its calculation to treat infinite stoichiometric ratios as cases that are 100% carbon. This will complicate some of litter model calculations but should have minimal effect elsewhere.
Describe alternatives you've considered
I did consider adding a step to just crash the model when an infinite stoichiometric ratio is returned, but I think this is probably overly restrictive
The text was updated successfully, but these errors were encountered:
I did consider adding a step to just crash the model when an infinite stoichiometric ratio is returned, but I think this is probably overly restrictive
That seems like the easiest solution right now? Also, I suspect it's a biologically realistic reason to crash? Unless there is some pure carbohydrate excretion - and even then, can that really be perfectly pure? Depends how hard it is to fix the edge case.
The annoying case is the zero carbon flow case, where the total flow is zero but the stoichiometric ratio is infinite, but maybe Taran could catch that specific case and I could throw an error if an infinity slips through
Is your feature request related to a problem? Please describe.
In #726 @TaranRallings has started calculating stoichiometries for matter flows being supplied to the litter model (they were previously just constants being fed to the litter model). This is all well and good but introduces the edge case where the input has an infinite stoichiometric ratio, i.e. the input is pure carbon. At present, this edge case (which we only rarely expect) causes the entire model to stall.
Describe the solution you'd like
The litter model can amend its calculation to treat infinite stoichiometric ratios as cases that are 100% carbon. This will complicate some of litter model calculations but should have minimal effect elsewhere.
Describe alternatives you've considered
I did consider adding a step to just crash the model when an infinite stoichiometric ratio is returned, but I think this is probably overly restrictive
The text was updated successfully, but these errors were encountered: