Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes google-oauth dependency #83

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Removes google-oauth dependency #83

merged 1 commit into from
Jul 11, 2023

Conversation

cgorman
Copy link
Collaborator

@cgorman cgorman commented Jun 7, 2023

google-oauth seems to be a dead project and is not/no longer used anywhere in this package. I'm having issues installing the package currently due to this dependency. I think the build is no longer available? My one hesitation is that I can't seem to find where this library was ever used so there may be something I'm missing. @hackermd can you shed any light on this?

@cgorman cgorman added the bug Something isn't working label Jun 7, 2023
@cgorman cgorman requested a review from hackermd June 7, 2023 22:21
@hackermd
Copy link
Collaborator

@cgorman not sure why this dependency was added. If it's not needed, let's remove it.

@cgorman cgorman merged commit 3d93d52 into master Jul 11, 2023
@cgorman
Copy link
Collaborator Author

cgorman commented Jul 11, 2023

Oops, sorry for the delay in merging. I think I had seen the approval and marked it off of my mental list without actually completing it.

@cgorman cgorman deleted the patch/gcp-deps branch July 11, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants