Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Utils.LowerDashed function #1171

Merged
merged 3 commits into from
Nov 14, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/core/util/Util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,11 @@ export class Util {
* lower-dashed string
*/
public static lowerDashed(text: string) {
return text.replace(/\s+/g, "-").toLowerCase();
const regex = new RegExp("[\\s]+|([\\p{Ll}](?=[\\p{Lu}\\p{Nd}]))", "gu");
const result = text.trim()
.replace(regex, "$1-")
.toLowerCase();
return result;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion spec/acceptance/new-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe("New command", () => {
expect(fs.existsSync("./jQuery Proj")).toBeTruthy();
expect(filesDiff("../templates/jquery/js/projects/empty/files", "./jQuery Proj")).toEqual([]);
const packageText = fs.readFileSync("./jQuery Proj/package.json", "utf-8");
expect(JSON.parse(packageText).name).toEqual("jquery-proj");
expect(JSON.parse(packageText).name).toEqual("j-query-proj");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's kind of worse though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this is exactly what we fix - does not look nice for jQuerry

expect(fs.existsSync("./jQuery Proj/.gitignore")).toBeTruthy();
testFolder = "./jQuery Proj";

Expand Down
Loading