Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using upgrade-packages throws an error for Angular projects with workspaces containing ng-package.json file #1298

Open
dobromirts opened this issue Aug 1, 2024 · 1 comment · May be fixed by #1347
Open

Using upgrade-packages throws an error for Angular projects with workspaces containing ng-package.json file #1298

dobromirts opened this issue Aug 1, 2024 · 1 comment · May be fixed by #1347
Assignees
@jackofdiamond5
Labels
cli-package igniteui-cli package core @igniteui/cli-core package 🏃 priority: high ✅ status: resolved

Comments

@dobromirts
Copy link

Description

When npx ng g @igniteui/angular-schematics:upgrade-packages is used in project that contains ng-package.json file , 'hasOwnProperty' error will be thrown due to the included ng-package.json in pkgJsonFiles collection and it does not contains dependencies.
image

  • Ignite UI CLI version: all
  • Framework: Angular

Steps to reproduce

  1. Open angular project with workspaces and 'ng-package.json' file.
  2. Run npx ng g @igniteui/angular-schematics:upgrade-packages

Result

image

Expected result

The packages and references to be updated to the official version.
@dobromirts dobromirts added core @igniteui/cli-core package cli-package igniteui-cli package labels Aug 1, 2024
@github-actions GitHub Actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@jackofdiamond5 jackofdiamond5 linked a pull request Nov 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackofdiamond5 jackofdiamond5

Labels
cli-package igniteui-cli package core @igniteui/cli-core package 🏃 priority: high ✅ status: resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pattern matching when upgrading packages IgniteUI/igniteui-cli
3 participants
@Lipata @jackofdiamond5 @dobromirts