Update dependencies #122
Merged
Update dependencies #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalance
force-pushed
the
update_dependencies
branch
2 times, most recently
from
01fa555 to
d09e5f2
Compare
eldesh
requested changes
Jun 15, 2022
| @@ -140,7 +138,7 @@ pub struct HyperClient { | |||
|
|
|||
| fn join_uri(uri: &Uri, path: &str) -> Result<Uri> { | |||
| let joined = format!("{}{}", uri.to_string(), path); | |||
| Ok(Uri::from_str(&joined).context(ErrorKind::InvalidUri { var: joined })?) | |||
There was a problem hiding this comment.
The value var of InvalidUri is required.
This is because we need to know what string caused the parsing error when we tried to parse it.
| @@ -276,7 +273,7 @@ impl HyperClient { | |||
| builder.add_root_certificate(ca); | |||
| // This ensures that using docker-machine-esque addresses work with Hyper. | |||
| let addr_https = addr.clone().replacen("tcp://", "https://", 1); | |||
| let url = Uri::from_str(&addr_https).context(ErrorKind::InvalidUri { var: addr_https })?; | |||
| @@ -287,7 +284,7 @@ impl HyperClient { | |||
| pub fn connect_with_http(addr: &str) -> result::Result<Self, Error> { | |||
| // This ensures that using docker-machine-esque addresses work with Hyper. | |||
| let addr_https = addr.clone().replace("tcp://", "http://"); | |||
| let url = Uri::from_str(&addr_https).context(ErrorKind::InvalidUri { var: addr_https })?; | |||
dalance
force-pushed
the
update_dependencies
branch
from
4769d25 to
65a05fd
Compare
dalance
force-pushed
the
update_dependencies
branch
from
65a05fd to
2eaa13b
Compare
|
I fixed |
|
Looks good 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies to resolve vulnerabilities.