Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes at uniforms.fogColor.value.copy( fog.color ); when uniforms.fogColor.value is null #58

Open
lorikou opened this issue Sep 1, 2020 · 0 comments

Comments

@lorikou
Copy link

lorikou commented Sep 1, 2020

Description:
I have written an web game-application with a-frame and I'm using -among others - the aframe particle system component along with the aframe environment component .
When rendering an entity that includes the aframe particle system component my app crashes and I get the following error:
Capture

This issue is resolved if I change the following line in aframe-master.js (line 32470)
uniforms.fogColor.value.copy( fog.color );
with this
if ( uniforms.fogColor.value ) uniforms.fogColor.value.copy( fog.color );
But that way the error will not be fixed permanently since it will be reproduced everytime someone reinstalls the npm packages.

I actually did manage to reproduce the error here (glitch). However this time the error is thrown directly from three.js. The app works just fine after I remove the component from the environment entity.
Capture
I quickly found that a newer version of the component called aframe-particle-system-component-fog-fix has been released, which supposedly exposes only a subset of the ShaderParticleEngine API. I had not made the switch, but after uninstalling the old one and installing the new, nothing changed.

Can somebody help me fix this?

  • A-Frame Version: 1.0.4
  • Platform / Device: Google Chrome on Windows 10 Desktop
  • Reproducible Code Snippet or URL: (glitch).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant