Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLES lib directory #284

Merged

Conversation

dgoetz
Copy link
Contributor

@dgoetz dgoetz commented Apr 20, 2017

This pull request fixes #283 by removing the architecture specific constants

@dnsmichi
Copy link

Can you fix the tests too please? :-)

@lazyfrosch lazyfrosch self-requested a review April 20, 2017 21:05
Copy link
Contributor

@lazyfrosch lazyfrosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine when tests go green. I suppose @dgoetz tested it on SUSE 👍

@lazyfrosch
Copy link
Contributor

Looks like the newest Puppetlabs modules on Forge bring us incompatibility problems with Puppet 3...

👍 for merging, we should address the Puppet 3 issues in testing elsewhere

@lazyfrosch
Copy link
Contributor

See #286

@bobapple bobapple removed the bug label Apr 21, 2017
@bobapple bobapple force-pushed the fix/suse_constants_283 branch from 4182a2c to dea1d91 Compare April 21, 2017 07:55
@bobapple bobapple changed the title fix suse architecture specific constants Update SLES lib directory Apr 21, 2017
@bobapple bobapple changed the base branch from master to fix/sles-lib-directory-283 April 21, 2017 08:34
@bobapple bobapple merged commit dea1d91 into voxpupuli:fix/sles-lib-directory-283 Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants