Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace selectors inside resource blocks #262

Closed
bobapple opened this issue Mar 20, 2017 · 0 comments
Closed

Replace selectors inside resource blocks #262

bobapple opened this issue Mar 20, 2017 · 0 comments
Assignees
@lbetz
Labels
bug
Milestone
v1.2.1

Comments

@bobapple
Copy link
Contributor

Regarding puppet-lint, it is not recommended to use selectors inside resource blocks. We do that a lot and should fix it.

Reference: http://puppet-lint.com/checks/selector_inside_resource/
@bobapple bobapple added the bug label Mar 20, 2017
@bobapple bobapple added this to the v1.2.1 milestone Mar 20, 2017
@lbetz lbetz self-assigned this Mar 20, 2017
@lbetz lbetz closed this as completed in 9a6ec9e Mar 20, 2017
@bobapple bobapple modified the milestones: v1.3.0, v1.2.1 Apr 7, 2017
n00by pushed a commit to n00by/puppet-icinga2 that referenced this issue Apr 26, 2018
@lbetz @n00by
fix voxpupuli#262 replace selectors inside resource block, improve co…
4051289 
…de quality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbetz lbetz

Labels
bug
Projects
None yet
Milestone
v1.2.1
Development

No branches or pull requests
2 participants
@bobapple @lbetz