Give the user a hint the first time they encounter a permision error. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Permission Error", without the information precisely which system/library call failed with which arguments is not all that helpful (and figuring out what exactly fails is not straightforward [1]), so after printing the error reply, point users to #313, which is likely the cause.
(Alternatively, one could also check capabilities during startup, e.g. using capget(2) or libcap. Might by worth it if any command a user can run needs these capabilities.)
--
[1] strace shows (apparently successful) interactions with both an eventfd (glib event loop related?) and a socket (the actual bluetooth stuff).