Gauge walks #211
Merged
Gauge walks #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
reviewed
Nov 26, 2024
|
Looks like a nice improvement. @JoeyT1994 will you be updating the ITensorTCI.jl PR to use a similar gauge_walk / gauge_edge / Algorithm design? |
|
Yes, the idea will be that I can then simplify that PR by removing most functions from the |
mtfishman
reviewed
Nov 29, 2024
| @@ -44,7 +45,7 @@ using MacroTools: @capture | |||
| using NamedGraphs: NamedGraphs, NamedGraph, not_implemented, steiner_tree | |||
| using NamedGraphs.GraphsExtensions: | |||
| ⊔, directed_graph, incident_edges, rename_vertices, vertextype | |||
| using NDTensors: NDTensors, dim | |||
| using NDTensors: NDTensors, dim, Algorithm | |||
There was a problem hiding this comment.
Let's load Algorithm from ITensor instead, since that is where you are loading @Algorithm_str.
|
Looks great, thanks! This will be very nice to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the
tree_orthogonalizecode totree_gaugecode which is based around a generic algorithm whichwalksthrough a series of edges of theITensorNetworkand performs some factorization which can be specified with analg::Algorithmargument.This means that we can support other
gaugessuch asinterpolativewith very minimal additional code (just one function which tells you how to do the edge factorizations).