Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš‘๏ธ Release hotfix/v1.55.1 (hotfix) #4409

Closed
15 tasks done
Tracked by #682
pcrespov opened this issue Jun 22, 2023 · 2 comments
Closed
15 tasks done
Tracked by #682

๐Ÿš‘๏ธ Release hotfix/v1.55.1 (hotfix) #4409

pcrespov opened this issue Jun 22, 2023 · 2 comments
Assignees
Labels
release Preparation for pre-release/release t:maintenance Some planned maintenance work
Milestone

Comments

@pcrespov
Copy link
Member

pcrespov commented Jun 22, 2023

Release version

1.55.1

Branch from Commit SHA

48d29cda9cb81c570fbd329ec560eb0c2167321a

Previous release

https://github.com/ITISFoundation/osparc-simcore/releases/tag/v1.55.0

Motivation

๐Ÿš‘๏ธ Hotfix branch

  • create hotfix branch hotfix_v1_55_x directly in upstream repo. Do not delete hotfix branches at least until next full release takes place.
  • prepare hotfix by applying patches/cherry-picks (see what changed section)
    • front-end -> static-webserver service
    • web-server service
    • auto-scale service
  • test hotfix in local deployment
  • push and check whether CI passed
  • check images in dockerhub

Changes

Releasing ๐Ÿš€

  • make release-hotfix version=1.55.1 git_sha=d2cfad629b4bdddde76504a84d68616aa7f6791c
  • Draft release notes ๐Ÿš€
  • No need for maintenance announcement? Target update of
    - webserver service
    - static-webserver service (new front-end)
    - autoscaling service
  • Deploy hot-fix.
  • Test and Monitor. Revert back if needed!
  • Announce hot-fix
:tada: https://github.com/ITISFoundation/osparc-simcore/releases/tag/v1.55.1
@pcrespov pcrespov added t:maintenance Some planned maintenance work release Preparation for pre-release/release labels Jun 22, 2023
@pcrespov pcrespov added this to the Watermelon milestone Jun 22, 2023
@pcrespov
Copy link
Member Author

  • @mrnicegyu11 We noticed that the deployment agents in production were active! For hotfixes this is pretty risky since we target update specific services in the stack and want to avoid a full update. It would be desirable to set scale=0 by default for the production-deployment-agent.

@mrnicegyu11
Copy link
Member

  • @mrnicegyu11 We noticed that the deployment agents in production were active! For hotfixes this is pretty risky since we target update specific services in the stack and want to avoid a full update. It would be desirable to set scale=0 by default for the production-deployment-agent.

Hi @pcrespov thanks for the feedback and the hotfix!

Having the deployment agent paused or disabled on prod should (in my eyes) be for exceptional situations only and every time it happens (and every day that it remains paused) should be a warning sign to us that we do something considered a bad practice, i.e. potentially "slow and hacky". At this time I would rather suggest leveling up our procedures so the deployment agent can be always on, as intended ;) I am not sure I am ready to just turn the guy off, we can continue this discussion in person if you want :)

And since maybe you dont know what I am talking about above: There is already today an intended way to do hotfixes with the deployment agent enabled, and this should be the way to go I guess, rather than the hacky approach with pausing it :) I can explain this in more details if anyone is interested

In case the deployment agent is actually having buggy behaviour or is causing troubles, we will of course shut it down ASAP and in investigate ;)

CC @matusdrobuliak66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Preparation for pre-release/release t:maintenance Some planned maintenance work
Projects
None yet
Development

No branches or pull requests

3 participants