Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

director-v2 mypy Part 3 followup #4150

Closed
GitHK opened this issue Apr 24, 2023 · 0 comments · Fixed by #4211
Closed

director-v2 mypy Part 3 followup #4150

GitHK opened this issue Apr 24, 2023 · 0 comments · Fixed by #4211
Assignees

Comments

@GitHK
Copy link
Contributor

GitHK commented Apr 24, 2023

Code refactoring is required for this one. The mixing idea is not idea. Better to create a utils module where to place this code.

src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler_mixin.py:40:13: error: "SchedulerInternalsMixin" has no attribute "_run_scheduler_task"; maybe "_scheduler_task"?  [attr-defined]
src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler_mixin.py:43:13: error: "SchedulerInternalsMixin" has no attribute "_run_trigger_observation_queue_task"; maybe "_trigger_observation_queue_task" or "_trigger_observation_queue"?  [attr-defined]
src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler_mixin.py:48:13: error: "SchedulerInternalsMixin" has no attribute "_cleanup_volume_removal_services"; maybe "_cleanup_volume_removal_services_task"?  [attr-defined]
src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler_mixin.py:51:15: error: "SchedulerInternalsMixin" has no attribute "_discover_running_services"  [attr-defined]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant