Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ remove code once it hits production #3990 #3996

Closed
GitHK opened this issue Mar 20, 2023 · 0 comments · Fixed by #4202
Closed

♻️ remove code once it hits production #3990 #3996

GitHK opened this issue Mar 20, 2023 · 0 comments · Fixed by #4202
Assignees
@GitHK

Comments

@GitHK
Copy link
Contributor

GitHK commented Mar 20, 2023 •
edited
Loading

once #3990 is in proaction remove the following validators:

  • ensure_defaults in packages/models-library/src/models_library/docker.py
  • _ensure_legacy_format_compatibility in services/director-v2/src/simcore_service_director_v2/models/schemas/dynamic_services/scheduler.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GitHK GitHK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♻️ Propagate can_save when starting service 🚨 GitHK/osparc-simcore-forked
1 participant
@GitHK