-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 📝 fixes/enhancements on the tooling repo-wide #2679
Merged
pcrespov
merged 15 commits into
ITISFoundation:master
from
pcrespov:maintenance/e2e-diagnostics
Dec 6, 2021
Merged
🐛 📝 fixes/enhancements on the tooling repo-wide #2679
pcrespov
merged 15 commits into
ITISFoundation:master
from
pcrespov:maintenance/e2e-diagnostics
Dec 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2679 +/- ##
========================================
+ Coverage 77.9% 78.1% +0.1%
========================================
Files 638 638
Lines 26093 26092 -1
Branches 2525 2526 +1
========================================
+ Hits 20351 20384 +33
+ Misses 5069 5040 -29
+ Partials 673 668 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
approved these changes
Dec 6, 2021
sanderegg
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR includes various fixes/enhancements on the tooling across the repository
watchmedo
ignore filter (used in theboot.sh
for development) to avoid unnecessary auto-restart of the apps while developing. E.g. now we can edit tests w/o triggering the full webserver to autorestart and wait a while until it restarts ( rest module takes >30secs ... !! but i leave a speed up for another PR)f"{my_var=}" -> "my_var=33"
tail
,inspect
,shell
recipes incommon.service.Makefile
check
recipe inapi/common/schemas/Makefile
python linting 3.10
CI job until we have bandwidth to fix it (received multiple complaints about it)How to test
common.service.Makefile
test include/exclude patterns
Getting the right ignore pattern sometimes is tricky because of the different implementation of the globs. I tested the
entrypoint
patterns usingwatchmedo log
as a replacement forwatchmedo auto-restart
. E.g.