-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨📝⚗️ Add config for github automatic changelog generation upon release #2662
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2662 +/- ##
=========================================
- Coverage 77.9% 69.4% -8.6%
=========================================
Files 638 270 -368
Lines 26093 8124 -17969
Branches 2525 707 -1818
=========================================
- Hits 20351 5639 -14712
+ Misses 5069 2333 -2736
+ Partials 673 152 -521
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Could you try this configuration in a repo owned by yourself in overt to test and debug it? I cannot tell how this is supposed to work from the docs alone. Maybe we can have some repo where we can test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! please check my unique comment;)
.github/release.yml
Outdated
- Removed: 🔥 Removed and Deprecated Features | ||
labels: | ||
- changelog:removal | ||
- changelog:deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might add a catch-all for the remaining features I think. just in case.
I guess we will anyway have to manually re-order some of them, or the ones where the labels are missing which I can already tell that will happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on the *
for the remaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this catchall "*" feature is not documented, did you come up with it or are you aware of some working undocumented functionalities? :D See https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
I might try it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition,
-
It actually complies again with the https://keepachangelog.com/en/1.0.0/. I suggest you add that in the comments of
.github/release.yml
-
It would also be handy if the labels
changelog:*
are listed in the comments of.github/PULL_REQUEST_TEMPLATE.md
as a reminder when doing PRs. I understand these labels need to be part of the commit message, right? For instance🐛 changelog:bufgix
✨ changelog:new-feature
♻️ changelog:refactor
.github/release.yml
Outdated
- Removed: 🔥 Removed and Deprecated Features | ||
labels: | ||
- changelog:removal | ||
- changelog:deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on the *
for the remaining
Question: could we add the emoticon in the title message and the label in the description? This way the logs in the header do not add this redundant tag 🔥 completely remove unused feature X bla bla bla changelog:removal |
@GitHK this is what it looks like on my private "playground" fork. I think the main goal for now is that we dont have to structure everything handily but get them sorted from the tags. Everything else is up for discussion afaic |
@pcrespov I implemented your suggestions. Also, the label will be added to the PR, not the commits. Or at least this is how I understood it |
if I understand this correctly we are getting new labels which as a contributor I have to add to the PR. This way I will help with the changeling generation. Is this correct? |
@GitHK yes |
nice I can already tag this PR! |
.github/PULL_REQUEST_TEMPLATE.md
Outdated
changelog:🐛bugfix | ||
changelog:🔒️security | ||
changelog:🔥removal | ||
changelog:⚰️deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahah the deprecation ... :-D
✨📝⚗️ Add config for github automatic changelog generation upon release
What do these changes do?
Added a config file for automatic changelog generation (will facilitate the manual tidying of changelog during releases). See:
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
Related issue/s
None
How to test
Should not impact CI. Will test correct recognition manually during next release.
Checklist