Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨📝⚗️ Add config for github automatic changelog generation upon release #2662

Closed
wants to merge 0 commits into from

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Nov 26, 2021

✨📝⚗️ Add config for github automatic changelog generation upon release

What do these changes do?

Added a config file for automatic changelog generation (will facilitate the manual tidying of changelog during releases). See:
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

Related issue/s

None

How to test

Should not impact CI. Will test correct recognition manually during next release.

Checklist

  • Check if it works upon next release of oSparc

@mrnicegyu11 mrnicegyu11 self-assigned this Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #2662 (554729e) into master (8d0ad6a) will decrease coverage by 8.5%.
The diff coverage is n/a.

❗ Current head 554729e differs from pull request most recent head 59f8bcd. Consider uploading reports for the commit 59f8bcd to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2662      +/-   ##
=========================================
- Coverage    77.9%   69.4%    -8.6%     
=========================================
  Files         638     270     -368     
  Lines       26093    8124   -17969     
  Branches     2525     707    -1818     
=========================================
- Hits        20351    5639   -14712     
+ Misses       5069    2333    -2736     
+ Partials      673     152     -521     
Flag Coverage Δ
integrationtests ?
unittests 69.4% <ø> (-4.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re-sdk/src/simcore_sdk/node_ports/serialization.py 25.0% <0.0%> (-57.4%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/nodeports.py 29.1% <0.0%> (-50.0%) ⬇️
...k/src/simcore_sdk/node_ports_common/filemanager.py 36.3% <0.0%> (-44.7%) ⬇️
...sdk/src/simcore_sdk/node_ports_common/dbmanager.py 43.0% <0.0%> (-43.1%) ⬇️
...es/simcore-sdk/src/simcore_sdk/node_ports/_item.py 66.4% <0.0%> (-28.0%) ⬇️
...sdk/src/simcore_sdk/node_ports/_data_items_list.py 55.2% <0.0%> (-10.6%) ⬇️
...k/src/simcore_sdk/node_ports/_schema_items_list.py 91.3% <0.0%> (-8.7%) ⬇️
...re_sdk/node_ports_common/client_session_manager.py 92.3% <0.0%> (-7.7%) ⬇️
...dk/src/simcore_sdk/node_ports_common/exceptions.py 70.3% <0.0%> (-7.5%) ⬇️
.../simcore_sdk/node_ports_common/data_items_utils.py 92.5% <0.0%> (-7.5%) ⬇️
... and 372 more

@GitHK
Copy link
Contributor

GitHK commented Nov 26, 2021

Could you try this configuration in a repo owned by yourself in overt to test and debug it? I cannot tell how this is supposed to work from the docs alone. Maybe we can have some repo where we can test it.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! please check my unique comment;)

- Removed: 🔥 Removed and Deprecated Features
labels:
- changelog:removal
- changelog:deprecation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a catch-all for the remaining features I think. just in case.
I guess we will anyway have to manually re-order some of them, or the ones where the labels are missing which I can already tell that will happen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the * for the remaining

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this catchall "*" feature is not documented, did you come up with it or are you aware of some working undocumented functionalities? :D See https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

I might try it later

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition,

  • It actually complies again with the https://keepachangelog.com/en/1.0.0/. I suggest you add that in the comments of .github/release.yml

  • It would also be handy if the labels changelog:* are listed in the comments of .github/PULL_REQUEST_TEMPLATE.md as a reminder when doing PRs. I understand these labels need to be part of the commit message, right? For instance

    🐛 changelog:bufgix
    ✨ changelog:new-feature
    ♻️ changelog:refactor

- Removed: 🔥 Removed and Deprecated Features
labels:
- changelog:removal
- changelog:deprecation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the * for the remaining

@pcrespov
Copy link
Member

pcrespov commented Nov 26, 2021

Question: could we add the emoticon in the title message and the label in the description? This way the logs in the header do not add this redundant tag


🔥 completely remove unused feature X

bla bla bla

changelog:removal


@pcrespov pcrespov added this to the Meerkat milestone Nov 26, 2021
@pcrespov pcrespov added a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work labels Nov 26, 2021
@mrnicegyu11
Copy link
Member Author

@GitHK this is what it looks like on my private "playground" fork. I think the main goal for now is that we dont have to structure everything handily but get them sorted from the tags. Everything else is up for discussion afaic
image

@mrnicegyu11
Copy link
Member Author

@pcrespov I implemented your suggestions. Also, the label will be added to the PR, not the commits. Or at least this is how I understood it

@GitHK
Copy link
Contributor

GitHK commented Nov 30, 2021

if I understand this correctly we are getting new labels which as a contributor I have to add to the PR. This way I will help with the changeling generation. Is this correct?

@mrnicegyu11
Copy link
Member Author

@GitHK yes

@GitHK
Copy link
Contributor

GitHK commented Nov 30, 2021

@GitHK yes

nice I can already tag this PR!

changelog:🐛bugfix
changelog:🔒️security
changelog:🔥removal
changelog:⚰️deprecation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahah the deprecation ... :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants