-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Replace auto-generated storage python client #2578
♻️ Replace auto-generated storage python client #2578
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2578 +/- ##
======================================
Coverage 77.1% 77.1%
======================================
Files 616 619 +3
Lines 23862 23931 +69
Branches 2343 2358 +15
======================================
+ Hits 18413 18471 +58
- Misses 4821 4826 +5
- Partials 628 634 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
213fd20
to
d90cc70
Compare
0773bc6
to
714096a
Compare
refactored added testing of client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Some minor stuff.
packages/simcore-sdk/src/simcore_sdk/node_ports_common/storage_client.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/src/simcore_sdk/node_ports_common/storage_client.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/src/simcore_sdk/node_ports_common/storage_client.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/src/simcore_sdk/node_ports_common/storage_client.py
Outdated
Show resolved
Hide resolved
packages/pytest-simcore/src/pytest_simcore/environment_configs.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/src/simcore_sdk/node_ports_common/storage_client.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
What do these changes do?
A long time ago we used the tool
openapi-generator-cli
for generating storage client code from its openapi specifications. This was useful at the time but since then we needed some specifc changes that made the generator cumbersome. Now the only remaining user of that client was node_ports package. in order to ease the migration to dask the client is now removed.Related issue/s
How to test
make build cd packages/simcore-sdk make tests
Checklist