-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Activate tracing in aiohttp-based services #2559
🐛 Activate tracing in aiohttp-based services #2559
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2559 +/- ##
========================================
+ Coverage 77.2% 78.3% +1.1%
========================================
Files 618 582 -36
Lines 23910 22934 -976
Branches 2356 2246 -110
========================================
- Hits 18472 17972 -500
+ Misses 4810 4333 -477
- Partials 628 629 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6736126
to
ef687d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Please find a few questions below.
packages/service-library/src/servicelib/aiohttp/rest_middlewares.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/aiohttp/rest_middlewares.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
646a864
to
5d7c2b6
Compare
5d7c2b6
to
d7ca909
Compare
What do these changes do?
Reviews and upgrades tracing helpers in
aiohttp
-based services, namelywebserver
,storage
anddirector
servicelib.tracing.setup_tracing
web-server
has still old settings. NeedsTRACING_ENABLED=1
(will be refactored as soon as we have new settings in place)storage
has new settings and can be configured usingSettings.STORAGE_TRACING
servicelib.aiohttp.rest_middlewares
doc and annotatedupgrades client to the latest release: could not be done due to a bug in library. Issue replicated in testaiozipkin==1.1.0
packages/service-library/tests/aiohttp/test_tracing.py