✨Adding tracing in fastapi-based services (⚠️ devops)

[sanderegg]

What do these changes do?

Related issue/s

We are missing a reliable way to monitor REST API calls. As we do have an infrastructure for this given by Jaeger we should use it!

⚠️ devops: add TRACING_THRIFT_COMPACT_ENDPOINT=http://jaeger:5775 in .env to correctly setup tracing

This PR activates tracing in the following services:

• catalog
• director-v2
• datcore-adapter
• dynamic-sidecar (still needs to be converted to settings-library @GitHK )
• api-server (still needs to be converted to settings-library @pcrespov )

Bonus:

• converted catalog to use settings-library
• setting the hostname in each service by using docker templates. This now is not enabled in the dask-sidecar for a reason that might be discovered later with the sidecar refactoring.

How to test

Checklist

[codecov]

Codecov Report

Merging #2558 (a57ad4d) into master (a50b617) will decrease coverage by 0.0%.
The diff coverage is 52.4%.

@@           Coverage Diff            @@
##           master   #2558     +/-   ##
========================================
- Coverage    77.2%   77.1%   -0.1%     
========================================
  Files         613     616      +3     
  Lines       23852   23862     +10     
  Branches     2338    2343      +5     
========================================
- Hits        18423   18413     -10     
- Misses       4801    4821     +20     
  Partials      628     628             

Flag	Coverage Δ
integrationtests	65.9% <100.0%> (+<0.1%)	⬆️
unittests	71.6% <52.4%> (-0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ibrary/src/models_library/settings/http_clients.py	0.0% <ø> (ø)
.../service-library/src/servicelib/fastapi/tracing.py	0.0% <0.0%> (ø)
.../settings-library/src/settings_library/postgres.py	90.6% <ø> (ø)
...s/catalog/src/simcore_service_catalog/db/events.py	44.8% <0.0%> (+1.4%)	⬆️
...rc/simcore_service_catalog/db/repositories/dags.py	40.5% <ø> (ø)
...rvices/catalog/src/simcore_service_catalog/main.py	0.0% <ø> (ø)
.../simcore_service_catalog/services/access_rights.py	26.5% <ø> (ø)
...c/simcore_service_catalog/core/background_tasks.py	29.7% <4.5%> (-3.6%)	⬇️
...g/src/simcore_service_catalog/services/director.py	41.8% <11.1%> (-1.1%)	⬇️
...catalog/src/simcore_service_catalog/core/events.py	57.5% <18.1%> (-1.5%)	⬇️
... and 13 more

[GitHK]

@sanderegg servicelib integration for dynamic-sidecar will come in via:

• ♻️✨adding nodeports support to dynamic-sidecar #2509

Have a look here, I think this should be enough.

osparc-simcore/services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py

Line 11 in 678162b

from settings_library.base import BaseSettings

[GitHK]

Looks nice! Glad this is coming in.

[pcrespov]

👍 Nice!
Just some minor comments!

[pcrespov]

You might also want to add the CLI? check how i did it in the api-server in PR #2563

[sanderegg]

@sanderegg servicelib integration for dynamic-sidecar will come in via:

• ♻️✨adding nodeports support to dynamic-sidecar #2509

Have a look here, I think this should be enough.

osparc-simcore/services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py

Line 11 in 678162b

from settings_library.base import BaseSettings

@GitHK : please see this PR concerning api-server. that is what is needed in the dynamic-sidecar.