Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bugfix: Copy thumbnail only if exists #2548

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 22, 2021

What do these changes do?

Copy thumbnail only if exists

Bonus

  • Ask for checkpoints only if can read

Before:
before

After:
after

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added this to the Capra delle nevi milestone Sep 22, 2021
@odeimaiz odeimaiz self-assigned this Sep 22, 2021
@odeimaiz odeimaiz changed the title Bugfix: Copy thumbnail only if exists 🐛 bugfix: Copy thumbnail only if exists Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2548 (a15ee42) into master (4645475) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2548     +/-   ##
========================================
- Coverage    76.9%   76.8%   -0.1%     
========================================
  Files         619     619             
  Lines       23968   23968             
  Branches     2345    2345             
========================================
- Hits        18437   18427     -10     
- Misses       4908    4915      +7     
- Partials      623     626      +3     
Flag Coverage Δ
integrationtests 65.4% <ø> (-0.1%) ⬇️
unittests 71.3% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._director_v2/modules/dynamic_sidecar/client_api.py 80.0% <0.0%> (-5.6%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 93.6% <0.0%> (-3.8%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 90.7% <0.0%> (-2.2%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 83.6% <0.0%> (-2.1%) ⬇️
.../director/src/simcore_service_director/producer.py 61.4% <0.0%> (+0.2%) ⬆️
...simcore_service_director_v2/modules/dask_client.py 92.5% <0.0%> (+1.6%) ⬆️

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected labels Sep 22, 2021
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for the quick fix!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
You might also want to review other required fields

@odeimaiz odeimaiz merged commit 5e2c146 into ITISFoundation:master Sep 22, 2021
@odeimaiz odeimaiz deleted the fix/start-study-with-service branch September 22, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants