Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test_swarm_runs failing 2/3 of the time #2450

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • Disable test_swarm_runs test that is testing:
    1. whether all services are up on the first trial
    2. implicitely should show that the services are up in a specific amount of time

Currently the problem is that most of the services are depending on postgres service being up and migrated by the migration service. If the computer running the stack is a bit slow, then we might have director-v2 trying to access tables that are not existing yet and then failing -> failing the test cause the director-v2 will be restarted.

For now we decided to disable the test since, we already have others that test whether all the services EVENTUALLY finally started and it seems to be ok for now.
Let's see if we end up having services needing 10 trials to start up in the next weeks.

closes #2430

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Jul 28, 2021
@sanderegg sanderegg added this to the Wombat milestone Jul 28, 2021
@sanderegg sanderegg self-assigned this Jul 28, 2021
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #2450 (b242a1a) into master (b5ab4b4) will decrease coverage by 8.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2450      +/-   ##
=========================================
- Coverage    74.6%   66.0%    -8.7%     
=========================================
  Files         574     134     -440     
  Lines       21658    3183   -18475     
  Branches     2078     217    -1861     
=========================================
- Hits        16166    2102   -14064     
+ Misses       4946    1036    -3910     
+ Partials      546      45     -501     
Flag Coverage Δ
integrationtests ?
unittests 66.0% <ø> (-4.0%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/service-library/src/servicelib/pools.py
...er/src/simcore_service_webserver/login/settings.py
...-library/src/models_library/api_schemas_storage.py
.../server/src/simcore_service_webserver/db_models.py
.../src/simcore_service_webserver/users_exceptions.py
...ices/sidecar/src/simcore_service_sidecar/config.py
...r/src/simcore_service_webserver/socketio/events.py
...es/catalog/src/simcore_service_catalog/api/root.py
...rc/simcore_service_webserver/login/registration.py
...rver/src/simcore_service_webserver/login/routes.py
... and 430 more

Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breathtaking

@sanderegg sanderegg merged commit 424d857 into ITISFoundation:master Jul 28, 2021
@sanderegg sanderegg deleted the maintenance/disable_constantly_failing_test branch July 28, 2021 14:53
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have already discussed on alternatives for rewriting this test, my original PR (closed by the current) was abandoned in favour of this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants