-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable test_swarm_runs failing 2/3 of the time #2450
Disable test_swarm_runs failing 2/3 of the time #2450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Codecov Report
@@ Coverage Diff @@
## master #2450 +/- ##
=========================================
- Coverage 74.6% 66.0% -8.7%
=========================================
Files 574 134 -440
Lines 21658 3183 -18475
Branches 2078 217 -1861
=========================================
- Hits 16166 2102 -14064
+ Misses 4946 1036 -3910
+ Partials 546 45 -501
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breathtaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have already discussed on alternatives for rewriting this test, my original PR (closed by the current) was abandoned in favour of this solution.
What do these changes do?
Currently the problem is that most of the services are depending on postgres service being up and migrated by the migration service. If the computer running the stack is a bit slow, then we might have director-v2 trying to access tables that are not existing yet and then failing -> failing the test cause the director-v2 will be restarted.
For now we decided to disable the test since, we already have others that test whether all the services EVENTUALLY finally started and it seems to be ok for now.
Let's see if we end up having services needing 10 trials to start up in the next weeks.
closes #2430
Related issue/s
How to test
Checklist