-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 New settings-library for settings #2395
Merged
pcrespov
merged 29 commits into
ITISFoundation:master
from
pcrespov:refactor/common-settings
Jun 28, 2021
Merged
🔨 New settings-library for settings #2395
pcrespov
merged 29 commits into
ITISFoundation:master
from
pcrespov:refactor/common-settings
Jun 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2395 +/- ##
========================================
- Coverage 74.1% 73.3% -0.8%
========================================
Files 523 532 +9
Lines 20415 20576 +161
Branches 2017 2025 +8
========================================
- Hits 15131 15091 -40
- Misses 4766 4959 +193
- Partials 518 526 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
20947c1
to
98262b5
Compare
sanderegg
approved these changes
Jun 28, 2021
6754842
to
358c700
Compare
GitHK
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
NEW
packages/settings-library
package for settings : implements new settings designed drafted in sample-app-settings repo.Highlights
settings_library.base
defines new base classBaseCustomSettings
:create_from_envs
constructorBaseCustomSettings.Config
settings_library.cli_utils
defines a factory to create settings commands for typer CLIsettings_library.celery, postgres, rabbit, redis, s3
reimplementsmodels_library.settings.*
using new settings designIn addition
pytest_simcore.cli_runner
storage
service: replacesmodel_library.settings
bysettings_library
Settings
Related issue/s
This is one of the four PR issued to refactor
settings
. The other are:🔨 Updates settings and removes config files: storage service #2369: refactors storage (merged)model_library.settings
bysettings_library
in the entire repoHow to test