-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes session cookies for /studies with latest aiohttp #2386
Merged
pcrespov
merged 9 commits into
ITISFoundation:master
from
pcrespov:is2008/fix-session-aiohttp-constraint
Jun 17, 2021
Merged
🐛 Fixes session cookies for /studies with latest aiohttp #2386
pcrespov
merged 9 commits into
ITISFoundation:master
from
pcrespov:is2008/fix-session-aiohttp-constraint
Jun 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aiohttp.web_protocol.RequestHandler._handler_request ignores cookies of HTTPException
Codecov Report
@@ Coverage Diff @@
## master #2386 +/- ##
========================================
- Coverage 74.8% 74.7% -0.1%
========================================
Files 516 516
Lines 20036 20038 +2
Branches 1972 1972
========================================
- Hits 14989 14984 -5
- Misses 4526 4530 +4
- Partials 521 524 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
changed the title
🐛 Fixes session cookies for /studies with latest aiohttp
WIP: 🐛 Fixes session cookies for /studies with latest aiohttp
Jun 17, 2021
pcrespov
changed the title
WIP: 🐛 Fixes session cookies for /studies with latest aiohttp
🐛 Fixes session cookies for /studies with latest aiohttp
Jun 17, 2021
GitHK
reviewed
Jun 17, 2021
mguidon
approved these changes
Jun 17, 2021
GitHK
approved these changes
Jun 17, 2021
16 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
aiohttp
(due to bug ⚗️ web-server refactoring backlog #2008) and upgrades all web-server dependenciesyarl
due to change in the quotation (see test for details)studies_access
Related issue/s
check aiohttp 3.7.3
)How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)