Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init celery application in app once + run call to blocking call in executor #2372

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • the celery application is initialized once at the beginning (will later need to check what happens if Rabbit/Redis are restarted) (but if scheduler is changed, then we might ditch this)
  • run call to celery inspect in executor

Related issue/s

How to test

Checklist

@sanderegg sanderegg added bug buggy, it does not work as expected a:webserver issue related to the webserver service labels Jun 8, 2021
@sanderegg sanderegg added this to the Chinchilla milestone Jun 8, 2021
@sanderegg sanderegg self-assigned this Jun 8, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #2372 (c9449d0) into master (dc4c691) will decrease coverage by 8.7%.
The diff coverage is 72.4%.

❗ Current head c9449d0 differs from pull request most recent head 0fbbb06. Consider uploading reports for the commit 0fbbb06 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2372     +/-   ##
========================================
- Coverage    74.3%   65.6%   -8.8%     
========================================
  Files         395     514    +119     
  Lines       16941   20019   +3078     
  Branches     1781    1967    +186     
========================================
+ Hits        12599   13146    +547     
- Misses       3870    6456   +2586     
+ Partials      472     417     -55     
Flag Coverage Δ
integrationtests ?
unittests 65.6% <72.4%> (-4.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/simcore_service_webserver/computation_utils.py 100.0% <ø> (ø)
...src/simcore_service_webserver/activity/handlers.py 27.1% <33.3%> (-62.9%) ⬇️
...simcore_service_webserver/activity/module_setup.py 52.6% <50.0%> (-47.4%) ⬇️
...imcore_service_webserver/activity/celery_client.py 75.0% <75.0%> (ø)
...r/src/simcore_service_webserver/activity/config.py 85.7% <100.0%> (-14.3%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 62.0% <100.0%> (-22.0%) ⬇️
...ackages/simcore-sdk/src/simcore_sdk/models/base.py 0.0% <0.0%> (-100.0%) ⬇️
...ges/simcore-sdk/src/simcore_sdk/models/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-91.2%) ⬇️
...es/web/server/src/simcore_service_webserver/cli.py 0.0% <0.0%> (-73.9%) ⬇️
... and 212 more

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flash SAN ⚡ !

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the bugfix/activity_handler_blocking_calls branch from e7a7adc to c9449d0 Compare June 8, 2021 13:24
@sanderegg sanderegg merged commit 92e6120 into ITISFoundation:master Jun 8, 2021
@sanderegg sanderegg deleted the bugfix/activity_handler_blocking_calls branch June 8, 2021 14:36
@sanderegg sanderegg modified the milestones: Chinchilla, Marmoset Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants