Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2e: guest study dispatcher #2362

Merged
merged 23 commits into from
Jun 3, 2021
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 1, 2021

What do these changes do?

  • Add vtk file study dispatcher portal2end test

Bonus:

  • Fix pagination bugs

puppeteering:
vtk_file

Related issue/s

closes #2320
closes #2321

How to test

Checklist

@odeimaiz odeimaiz changed the title vtk_file test added p2e: guest study dispatcher Jun 1, 2021
@odeimaiz odeimaiz self-assigned this Jun 1, 2021
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing labels Jun 1, 2021
@odeimaiz odeimaiz added this to the Chinchilla milestone Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #2362 (1058c7c) into master (ed7c992) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2362   +/-   ##
======================================
  Coverage    74.9%   74.9%           
======================================
  Files         513     513           
  Lines       20007   20007           
  Branches     1967    1967           
======================================
+ Hits        14994   14996    +2     
+ Misses       4497    4496    -1     
+ Partials      516     515    -1     
Flag Coverage Δ
integrationtests 67.4% <ø> (+<0.1%) ⬆️
unittests 68.4% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-v2/src/simcore_service_director_v2/core/errors.py 58.3% <0.0%> (-2.8%) ⬇️
...simcore_service_webserver/projects/projects_api.py 89.0% <0.0%> (+0.5%) ⬆️
...c/simcore_service_director_v2/modules/scheduler.py 96.7% <0.0%> (+1.6%) ⬆️

@odeimaiz odeimaiz marked this pull request as ready for review June 2, 2021 13:57
@odeimaiz odeimaiz merged commit c027086 into ITISFoundation:master Jun 3, 2021
@odeimaiz odeimaiz deleted the bugfix/pagination branch June 9, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing
Projects
None yet
4 participants