Bugfix/director v2 loop

[sanderegg]

What do these changes do?

director-v2 startup script creates 2 event loops when in production mode.

Also fixes other fastapi-based applications (catalog, api-server, dynamic-sidecar).

Related issue/s

How to test

Checklist

[codecov]

Codecov Report

Merging #2356 (f755b39) into master (6a51091) will increase coverage by 0.1%.
The diff coverage is 0.0%.

@@           Coverage Diff            @@
##           master   #2356     +/-   ##
========================================
+ Coverage    74.8%   75.0%   +0.1%     
========================================
  Files         513     513             
  Lines       20036   19998     -38     
  Branches     1967    1967             
========================================
+ Hits        14992   15003     +11     
+ Misses       4527    4484     -43     
+ Partials      517     511      -6     

Flag	Coverage Δ
integrationtests	67.4% <0.0%> (+0.1%)	⬆️
unittests	68.4% <0.0%> (+0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...er/src/simcore_service_api_server/core/settings.py	97.2% <ø> (-0.1%)	⬇️
.../api-server/src/simcore_service_api_server/main.py	0.0% <0.0%> (ø)
...talog/src/simcore_service_catalog/core/settings.py	96.2% <ø> (-0.2%)	⬇️
...rvices/catalog/src/simcore_service_catalog/main.py	0.0% <0.0%> (ø)
...2/src/simcore_service_director_v2/core/settings.py	95.6% <ø> (-0.1%)	⬇️
...irector-v2/src/simcore_service_director_v2/main.py	0.0% <0.0%> (ø)
...idecar/src/simcore_service_dynamic_sidecar/main.py	0.0% <ø> (ø)
... and 4 more

[pcrespov]

Pair reviewed.

I wonder if we should then remove these fields from the AppSettings related to uvicorn since they are now

    # SERVICE SERVER (see : https://www.uvicorn.org/settings/)
    host: str = "0.0.0.0"  # nosec
    port: int = 8000

since now they are fix values in the docker/boot.sh

[GitHK]

👍

[GitHK]

Pair reviewed.

I wonder if we should then remove these fields from the AppSettings related to uvicorn since they are now

    # SERVICE SERVER (see : https://www.uvicorn.org/settings/)
    host: str = "0.0.0.0"  # nosec
    port: int = 8000

since now they are fix values in the docker/boot.sh

If they are not used and it is not possible to overwrite them via env vars, I would remove them.

[pcrespov]

If they are not used and it is not possible to overwrite them via env vars, I would remove them.

@GitHK What do you mean? All attributes of pydantic setting classes can be set via environment variables

[GitHK]

If they are not used and it is not possible to overwrite them via env vars, I would remove them.

@GitHK What do you mean? All attributes of pydantic setting classes can be set via environment variables

Yes that's what my understanding of the BaseSettings class is. Read more here. You can see in the example they state that if there is env_prefix all names will be fetched form the environment without using one. In this case hostand port, if they are defined they will be fetched from there.