Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️Maintenance: remove all cache docker images #2353

Merged
merged 10 commits into from
May 28, 2021

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 28, 2021

What do these changes do?

  • migrated to buildX (make build now calls docker buildX)
  • fixed some issues between static-webserver dependencies and qooxdoo build
  • removed docker buildkit
  • fixed cache_from entries in docker-compose-build.yml

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label May 28, 2021
@sanderegg sanderegg added this to the Chinchilla milestone May 28, 2021
@sanderegg sanderegg self-assigned this May 28, 2021
@sanderegg sanderegg changed the title Maintenance: remove all caching Maintenance: remove all cache docker images May 28, 2021
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #2353 (a95dad2) into master (b6a838b) will increase coverage by 6.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2353     +/-   ##
========================================
+ Coverage    68.2%   74.4%   +6.1%     
========================================
  Files         508     508             
  Lines       19793   19793             
  Branches     1946    1946             
========================================
+ Hits        13510   14737   +1227     
+ Misses       5855    4544   -1311     
- Partials      428     512     +84     
Flag Coverage Δ
integrationtests 66.6% <ø> (?)
unittests 68.2% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/service-library/src/servicelib/aiopg_utils.py 87.5% <0.0%> (-3.2%) ⬇️
...re_service_webserver/projects/projects_handlers.py 90.2% <0.0%> (+0.3%) ⬆️
.../director/src/simcore_service_director/producer.py 61.0% <0.0%> (+0.4%) ⬆️
...simcore_service_webserver/director/director_api.py 66.6% <0.0%> (+1.3%) ⬆️
.../simcore_service_webserver/projects/projects_db.py 90.2% <0.0%> (+2.5%) ⬆️
...server/src/simcore_service_webserver/groups_api.py 91.6% <0.0%> (+2.5%) ⬆️
.../server/src/simcore_service_webserver/users_api.py 93.9% <0.0%> (+2.5%) ⬆️
...imcore_service_webserver/scicrunch/scicrunch_db.py 48.5% <0.0%> (+2.8%) ⬆️
...erver/src/simcore_service_webserver/director_v2.py 78.0% <0.0%> (+3.0%) ⬆️
...vices/sidecar/src/simcore_service_sidecar/utils.py 80.0% <0.0%> (+3.6%) ⬆️
... and 64 more

@sanderegg sanderegg requested review from pcrespov, GitHK and mguidon May 28, 2021 09:56
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -14,8 +14,9 @@ services:
dockerfile: services/api-server/Dockerfile
cache_from:
- local/api-server:${BUILD_TARGET:?build_target_required}
- ${DOCKER_REGISTRY:-itisfoundation}/api-server:cache
- ${DOCKER_REGISTRY:-itisfoundation}/api-server:${DOCKER_IMAGE_TAG:-latest}
- ${DOCKER_REGISTRY:-itisfoundation}/api-server:master-github-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice still caching from latest build.

@pcrespov
Copy link
Member

pcrespov commented May 28, 2021

Some proposals for next iterations on the static-webserver:

  • moving client compile as a stage of static-webserve/Dockerfile will accelerate image build (notice that make build-x always start compiling the front-end and cannot parallelize)
  • rename web/sever -> webserver so it follows the same pattern as the rest
  • move web/client outside of web. I suggest even outside services and have a clients folder so in the future we could even have multiple frontends? just a suggestion ...

@sanderegg sanderegg changed the title Maintenance: remove all cache docker images 🏗️Maintenance: remove all cache docker images May 28, 2021
@sanderegg sanderegg merged commit ad00db4 into ITISFoundation:master May 28, 2021
@sanderegg sanderegg deleted the remove_docker_caches branch May 28, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants