Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes slow calls #2346

Merged
merged 5 commits into from
May 25, 2021
Merged

Fixes slow calls #2346

merged 5 commits into from
May 25, 2021

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 25, 2021

What do these changes do?

  • FIX: Replaces tenacity.Retrying by non-blocking AsyncRetrying in async calls (thx to @GitHK )
 15.022 instrumented  servicelib/monitor_slow_callbacks.py:23
 └─ 15.022 _run  asyncio/events.py:143
    └─ 15.022 _run_app  aiohttp/web.py:279
       └─ 15.022 setup  aiohttp/web_runner.py:221
          └─ 15.022 _make_server  aiohttp/web_runner.py:327
             └─ 15.022 startup  aiohttp/web_app.py:384
                └─ 15.022 send  aiohttp/signals.py:26
                   └─ 15.022 _on_startup  aiohttp/web_app.py:492
                      └─ 15.022 pg_engines  simcore_service_webserver/db.py:82
                         └─ 15.022 _create_pg_engine  simcore_service_webserver/db.py:69
                            └─ 15.022 __iter__  tenacity/__init__.py:395
                               └─ 15.022 sleep  tenacity/nap.py:22
                                  └─ 15.022 sleep  ../../<built-in>:0 -
  • FIX: extends timeout in scripts/maintenance/clean_projects_of_user.py
  • CHANGED: increased timeout for CI (github actions seem to go slower)

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #2346 (7fd5015) into master (9a64948) will increase coverage by 0.0%.
The diff coverage is 75.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2346   +/-   ##
======================================
  Coverage    74.6%   74.6%           
======================================
  Files         508     508           
  Lines       19772   19775    +3     
  Branches     1943    1944    +1     
======================================
+ Hits        14753   14757    +4     
+ Misses       4505    4504    -1     
  Partials      514     514           
Flag Coverage Δ
integrationtests 66.7% <70.0%> (-0.1%) ⬇️
unittests 68.3% <75.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ces/web/server/src/simcore_service_webserver/db.py 68.1% <66.6%> (ø)
...imcore_service_webserver/resource_manager/redis.py 91.1% <71.4%> (-4.2%) ⬇️
services/storage/src/simcore_service_storage/db.py 70.2% <100.0%> (ø)
...ages/service-library/src/servicelib/aiopg_utils.py 90.6% <0.0%> (+3.1%) ⬆️

@pcrespov pcrespov changed the title Fix/slow calls Fixes slow calls May 25, 2021
@pcrespov pcrespov self-assigned this May 25, 2021
@pcrespov pcrespov added this to the Chinchilla milestone May 25, 2021
@pcrespov pcrespov requested review from sanderegg, GitHK and mguidon May 25, 2021 11:56
@pcrespov pcrespov marked this pull request as ready for review May 25, 2021 11:57
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great, thanks for fixing this!

scripts/maintenance/clean_projects_of_user.py Outdated Show resolved Hide resolved
@pcrespov pcrespov merged commit cbcc3c2 into ITISFoundation:master May 25, 2021
@pcrespov pcrespov deleted the fix/slow-calls branch May 25, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants