-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring webserver: async metrics handler, upgrades dependencies and fixes testing fixtures #2343
Refactoring webserver: async metrics handler, upgrades dependencies and fixes testing fixtures #2343
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2343 +/- ##
========================================
+ Coverage 73.0% 74.6% +1.5%
========================================
Files 508 508
Lines 19768 19772 +4
Branches 1943 1943
========================================
+ Hits 14436 14751 +315
+ Misses 4846 4506 -340
- Partials 486 515 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
915c2bb
to
3900657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! just concerning the thread pool quickly check my comment there before merging.
services/web/server/src/simcore_service_webserver/diagnostics_monitoring.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/diagnostics_monitoring.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice overall.
One concern, as said below. Why not replace the prometheus client with the async version?
services/web/server/src/simcore_service_webserver/diagnostics_monitoring.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/diagnostics_monitoring.py
Show resolved
Hide resolved
5c83933
to
ef900eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Did you think about using celery for the metrics generation?
What do these changes do?
General maintenance of the
webserver
metrics_handler
implementation async by using a thread pool executor ot executeprometheos_client.generate_latest
callaiohttp
andpython-socketio
cannot be upgraded to the latest. Needs further refactoring (see ⚗️ web-server refactoring backlog #2008 and notes in requirement files)!services/web/server/tests/integration/01/test_exporter.py
was de-activated.pytest-simcore
utilssimcore-pytest
Next steps (different PRs)
Related issue/s
Towards spliting webserver
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)