🏗️ Maintenance/set locust image #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and pushed to dockerhub
GitHK
approved these changes
May 18, 2021
| @@ -2,7 +2,7 @@ version: '3.8' | |||
|
|
|||
| services: | |||
| master: | |||
| image: local/locust:latest | |||
| image: itisfoundation/locust:${LOCUST_VERSION} | |||
There was a problem hiding this comment.
are you sure about the itisfoundation as a prefix for images?
mguidon
approved these changes
May 18, 2021
pcrespov
changed the title
pcrespov
reviewed
May 18, 2021
There was a problem hiding this comment.
should this be better in https://github.com/ITISFoundation/dockerfiles?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
pin locust version and pushes it to dockerhub so it is accessible from p2p test
Related issue/s
How to test
Checklist