-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: make listing of S3 objects faster in storage #2329
Bugfix: make listing of S3 objects faster in storage #2329
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2329 +/- ##
========================================
- Coverage 71.7% 71.7% -0.1%
========================================
Files 506 506
Lines 19925 19926 +1
Branches 1950 1950
========================================
- Hits 14303 14288 -15
- Misses 5146 5160 +14
- Partials 476 478 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subtle! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow
What do these changes do?
calling aiobotocore.list_objects_v2 method with a Prefix is several order of magnitudes faster when Prefix is ending with a /
e.g.:
looking for files in of project 0000802f-1e81-551f-8ab2-769c941aac66:
for example on master, the first call takes 12 seconds to complete... while the second call takes a few ms...
Related issue/s
How to test
Checklist