Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ maintenance: upgrade minio #2326

Merged
merged 3 commits into from
May 11, 2021

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 10, 2021

What do these changes do?

Upgrades to latest minio 7.0.3 in the entire repository:

  • In a separate PR because this version has API breaking changes
  • Affects mainly:
    • storage service: services/storage/src/simcore_service_storage/s3wrapper
    • modules using pytest_simcore/minio_service.py test fixtures (i.e. simcore-sdk, storage, tests/swarm-deploy and sidecar``

Related issue/s

How to test

manual

  • build and deploy prod: make build-x; make up-prod
  • login and create a study
  • drop some files (will convert into file-picker)
  • create template
  • use a template

unit

make devenv
source .venv/bin/activate
cd services/storage
make install-dev
pytest  tests/s3wrapper

Checklist

  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes

@pcrespov pcrespov self-assigned this May 10, 2021
@pcrespov pcrespov added a:storage issue related to storage service t:maintenance Some planned maintenance work labels May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #2326 (42e369c) into master (f82a31b) will increase coverage by 0.0%.
The diff coverage is 51.5%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2326   +/-   ##
======================================
  Coverage    71.7%   71.7%           
======================================
  Files         506     506           
  Lines       19934   19927    -7     
  Branches     1949    1950    +1     
======================================
- Hits        14303   14302    -1     
+ Misses       5153    5148    -5     
+ Partials      478     477    -1     
Flag Coverage Δ
integrationtests 61.9% <ø> (+<0.1%) ⬆️
unittests 67.1% <51.5%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ervices/storage/src/simcore_service_storage/dsm.py 72.5% <ø> (-0.1%) ⬇️
...src/simcore_service_storage/s3wrapper/s3_client.py 68.9% <51.5%> (+1.3%) ⬆️
...ce_webserver/resource_manager/garbage_collector.py 75.7% <0.0%> (+0.9%) ⬆️

@pcrespov pcrespov requested review from mguidon, sanderegg and GitHK May 10, 2021 19:41
@pcrespov pcrespov marked this pull request as ready for review May 10, 2021 19:53
@pcrespov pcrespov added this to the Chinchilla milestone May 10, 2021
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@pcrespov pcrespov merged commit 26a1177 into ITISFoundation:master May 11, 2021
@pcrespov pcrespov deleted the maintenance/upgrade-minio branch May 11, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants