-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates pagination #2292
Merged
odeimaiz
merged 13 commits into
ITISFoundation:master
from
odeimaiz:feature/template-pagination
Apr 23, 2021
Merged
Templates pagination #2292
odeimaiz
merged 13 commits into
ITISFoundation:master
from
odeimaiz:feature/template-pagination
Apr 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2292 +/- ##
======================================
Coverage 71.6% 71.6%
======================================
Files 488 488
Lines 19286 19286
Branches 1897 1897
======================================
+ Hits 13814 13819 +5
+ Misses 5010 5007 -3
+ Partials 462 460 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty!
pcrespov
approved these changes
Apr 23, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR implements the paginated templates calls in the frontend.
For demo purposes, we call 5 by 5:
![pagination](https://user-images.githubusercontent.com/33152403/115881515-1d3def00-a44c-11eb-8db7-ad7c5ebf25c5.gif)
Related issue/s
Related to platform scalability ITISFoundation/osparc-issues#428
How to test
Checklist