Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates pagination #2292

Merged
merged 13 commits into from
Apr 23, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 23, 2021

What do these changes do?

This PR implements the paginated templates calls in the frontend.

For demo purposes, we call 5 by 5:
pagination

Related issue/s

Related to platform scalability ITISFoundation/osparc-issues#428

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Apr 23, 2021
@odeimaiz odeimaiz marked this pull request as draft April 23, 2021 10:29
@odeimaiz odeimaiz added this to the Schwarznasenschaf milestone Apr 23, 2021
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #2292 (756148d) into master (98281db) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2292   +/-   ##
======================================
  Coverage    71.6%   71.6%           
======================================
  Files         488     488           
  Lines       19286   19286           
  Branches     1897    1897           
======================================
+ Hits        13814   13819    +5     
+ Misses       5010    5007    -3     
+ Partials      462     460    -2     
Flag Coverage Δ
integrationtests 62.0% <ø> (-0.1%) ⬇️
unittests 66.8% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 61.7% <0.0%> (+1.0%) ⬆️

@odeimaiz odeimaiz marked this pull request as ready for review April 23, 2021 13:44
@odeimaiz odeimaiz changed the title WIP: Templates pagination Templates pagination Apr 23, 2021
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty!

@odeimaiz odeimaiz merged commit dfe92b5 into ITISFoundation:master Apr 23, 2021
@odeimaiz odeimaiz deleted the feature/template-pagination branch August 23, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants