-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗️ Upgrades repository to python 3.8.10 #2079
🏗️ Upgrades repository to python 3.8.10 #2079
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2079 +/- ##
========================================
- Coverage 74.8% 74.2% -0.7%
========================================
Files 517 518 +1
Lines 20161 20320 +159
Branches 2000 2012 +12
========================================
- Hits 15083 15080 -3
- Misses 4544 4716 +172
+ Partials 534 524 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e8fb3e1
to
625319e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job. Thanks a lot for upgrading to 3.8! I have a few questions below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing maybe missing is:
- installation of pyenv as part of some makefile recipe (or maybe just a link to pyenv?)
76703a4
to
757ecbc
Compare
bbf6996
to
0fb97b3
Compare
0fb97b3
to
272cf81
Compare
272cf81
to
f4d3dd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've requested a few changes, they will avoid some pain when testing.
services/web/server/src/simcore_service_webserver/computation_comp_tasks_listening_task.py
Show resolved
Hide resolved
services/web/server/tests/unit/isolated/test_exporter_archiving.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/isolated/test_exporter_archiving.py
Outdated
Show resolved
Hide resolved
5a8f495
to
c58b0ff
Compare
…g service responses
2f8c4b2
to
5b00a5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet!
What do these changes do?
director
whose development is frozen], to python 3.8.10. See what is newrequirements/PYTHON_VERSION
( repo checked usingtests/environment-setup/test_used_python.py
)python-linting
that is run in both 3.8 and 3.9Main changes
python_requires
specs onsetup.py
and other metadata/checksrequirements/tools/Dockerfile
requirements/packages-notes.md
for more details).pre-commit-config.yaml
) etcgarbage_collector.py
ignores cancellation and enters in an errors loop. I am still not sure what is the cause so I introduced a mechanism to enforce getting out of the infinitewhile True
loop.Some highlights in 3.8
asyncio.run(coro())
python -m asyncio
creates an asyncio REPL 3.8.0Related issue/s
How to test
pyenv install --list | grep 3.8
pyenv install 3.8.6
pyenv versions
osparc-simcore
project. Will create a.python-version
file:cd osparc-simcore pyenv local 3.8.10 python --version
Checklist
CancelledError
is not inasyncio.future
anymoreFuture
to emulate a coroutine.pylint
(has some issues with 3.9)