Wait for pid to disappear and tidy #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
DominicOram
reviewed
Feb 26, 2018
| self._prompt.prompt_and_raise_if_not_yes( | ||
| "Stopping the MySQL service failed. Please do it manually") | ||
| except OSError: | ||
| RunProcess(SYSTEM_SETUP_PATH, "mysql.exe", executable_directory=mysql_bin_dir, |
There was a problem hiding this comment.
Do these have to be run from the SYSTEM_SETUP_PATH? At this point we don't know if that path exists.
There was a problem hiding this comment.
In fact, if you've chosen to backup the EPICS directory it has been moved earlier in the script and this will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the pid of the mysql process to disappear before backing up database.
Split large python file into smaller files.
Use run process.