Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

McLennan: improve logging and diagnostics #7727

Closed
FreddieAkeroyd opened this issue May 9, 2023 · 2 comments
Closed

McLennan: improve logging and diagnostics #7727

FreddieAkeroyd opened this issue May 9, 2023 · 2 comments
Assignees
Labels

Comments

@FreddieAkeroyd
Copy link
Member

FreddieAkeroyd commented May 9, 2023

As a developer i would like it to be clearer when there is an issue with the mclennan. This ticket adds various improvements:

  • dbior command prints more details
  • mclennan change of status (e.g. moving, tracking abort) now printed to log file
  • hardware homing does not use SNL for zeroing
  • some other default setting from labview now applied on startup
  • Also added switch settings and encoder resolution notes to wiki https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/McLennan-motors
  • extended emulator and tests
  • fixed some use of uninitialised memory and duplicate command issues in driver

acceptance criteria

  • Tests run ok
  • MacLennan behaviour in office correct, can move and home. I believe this has both a hardware home option and limit switches
  • Check ioc log see messages printed about above actions etc about homing, moving. these messages should reflect same status as displayed on crate front panel.
  • console to ioc and type dbior and dbior * 1 and check get output, the latter should have the extensive QA command output
@FreddieAkeroyd
Copy link
Member Author

@rerpha have updated ioc/motor/emulator to support HVEL macro and also return output from QA via dbior - see acceptance criteria

@rerpha
Copy link
Contributor

rerpha commented May 17, 2023

Think I am happy with changes, but still need to test on office mclennan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants