Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kepco: communication improvements #7719

Closed
FreddieAkeroyd opened this issue May 2, 2023 · 1 comment
Closed

kepco: communication improvements #7719

FreddieAkeroyd opened this issue May 2, 2023 · 1 comment

Comments

@FreddieAkeroyd
Copy link
Member

As a developer I would like to remove ExtraInput = ignore from the kepco protocol https://github.com/ISISComputingGroup/EPICS-kepco/blob/master/kepcoApp/protocol/kepco.proto as it potentially increases the chance of a corrupt reply being interpreted as a good one.

We may also want to consider adding ;*OPC? to the end of set commands which should return 1 when it completes, however i might have already tries this and found our cards did not support it
@FreddieAkeroyd FreddieAkeroyd mentioned this issue May 2, 2023
Closed
1 task
@davidkeymer davidkeymer mentioned this issue May 10, 2023
Closed
2 tasks
@KathrynBaker
Copy link
Member

Closing in favour of #7778 which is more comprehensive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FreddieAkeroyd @KathrynBaker