Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBEX GUI: Add motor controller field in ToM motor details #7418

Closed
1 task
rerpha opened this issue Oct 11, 2022 · 5 comments
Closed
1 task

IBEX GUI: Add motor controller field in ToM motor details #7418

rerpha opened this issue Oct 11, 2022 · 5 comments
Assignees

Comments

@rerpha
Copy link
Contributor

rerpha commented Oct 11, 2022

As a developer/ops person i would like a field in the table of motors advanced view which tells me what type of motor controller an axis is being driven by. this would mean we don't have to dig into macros/globals/the settings area to figure it out.

Acceptance Criteria

What is the acceptance criteria?

  • a field is shown in the ToM advanced view which says galil/beckhoff/smc100/mclennan/linmot etc.

Extra Information

we could load in a controller id record in addition to the motor record if we want to be consistent?

does the motor record have any support for this already?

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)

@rerpha rerpha added the Friday label Oct 11, 2022
@Tom-Willemsen
Copy link
Contributor

Does it actually need to be in the ToM or would displaying it on the motor + motor details OPIs be sufficient? Asking because the advanced ToM is already pretty crowded...

@rerpha
Copy link
Contributor Author

rerpha commented Oct 11, 2022

Does it actually need to be in the ToM or would displaying it on the motor + motor details OPIs be sufficient? Asking because the advanced ToM is already pretty crowded...

sorry, motor details is what i meant, forgot about the actual advanced view which shows motor energised etc.

@rerpha rerpha changed the title IBEX GUI: Add motor controller field in ToM advanced view IBEX GUI: Add motor controller field in ToM motor details Oct 11, 2022
@rerpha rerpha self-assigned this Oct 13, 2022
@rerpha
Copy link
Contributor Author

rerpha commented Oct 14, 2022

IOC: ISISComputingGroup/EPICS-ioc#740
motor: ISISComputingGroup/EPICS-motor#51
galil (uses galil motor extras rather than motorstatus.db): ISISComputingGroup/EPICS-galil#67
gui: ISISComputingGroup/ibex_gui#1491
RN: #7423

@rerpha
Copy link
Contributor Author

rerpha commented Oct 14, 2022

ps, deliberately left out the sm300 as we are removing it

@rerpha rerpha added the 2 label Oct 14, 2022
@rerpha rerpha added this to the SPRINT_2022_10_06 milestone Oct 14, 2022
@rerpha
Copy link
Contributor Author

rerpha commented Oct 14, 2022

To review start a GALIL_01 and GALIL_02 in DEVSIM and a mclennan (and any others you fancy testing) and check in motor details page at bottom of status group box that the ioc name matches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants