Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motionsetpoints: OFFSET:SP missing units #7332

Closed
1 task
rerpha opened this issue Sep 6, 2022 · 4 comments
Closed
1 task

Motionsetpoints: OFFSET:SP missing units #7332

rerpha opened this issue Sep 6, 2022 · 4 comments

Comments

@rerpha
Copy link
Contributor

rerpha commented Sep 6, 2022

OFFSET gets .EGU set by the substitution files, but OFFSET:SP does not:

Screenshot 2022-09-06 153148

In this example the SP should have "deg" as that is the underlying .EGU of the motor record. This is because it's missing from the unit setter substitution which means it defaults to "mm" as this is is the default VAL field in the single axis template.

Acceptance criteria

  • OFFSET:SP has the same units as the motor record it will be acting on
@rerpha
Copy link
Contributor Author

rerpha commented Sep 6, 2022

@rerpha rerpha self-assigned this Sep 6, 2022
@rerpha rerpha added the 2 label Sep 6, 2022
@rerpha rerpha added this to the SPRINT_2022_08_15 milestone Sep 6, 2022
@rerpha rerpha added the bug label Sep 6, 2022
@github-actions github-actions bot added the review label Sep 6, 2022
@Tom-Willemsen
Copy link
Contributor

Reviewer: please double check this doesn't cause a regression of #6423 because of #6433

@FreddieAkeroyd
Copy link
Member

I've proposed we do #6433 next sprint

@JackEAllen
Copy link
Member

Reviewer: please double check this doesn't cause a regression of #6423 because of #6433

I believe this does not cause a regression of #6423 as we are using NPP as default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants