Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFFSPEC: Add OPIs for Reflectometry Front Panel #7328

Closed
ThomasLohnert opened this issue Sep 5, 2022 · 0 comments · Fixed by #7354 or ISISComputingGroup/ibex_gui#1476
Closed

OFFSPEC: Add OPIs for Reflectometry Front Panel #7328

ThomasLohnert opened this issue Sep 5, 2022 · 0 comments · Fixed by #7354 or ISISComputingGroup/ibex_gui#1476
Assignees
Labels

Comments

@ThomasLohnert
Copy link
Contributor

ThomasLohnert commented Sep 5, 2022

As a OFFSPEC user/scientist, I would like to be able to see essential parameters on the reflectometry front panel. At the moment, the beamline specific panels that get loaded by the reflectometry front panel have not yet been created so that part of the front panel is currently just blank.

Acceptance Criteria

  • There is an OPI for OFFSPEC displaying each of the following (same as for existing instruments):
    • A panel with all relevant HGAP parameters
      • S1HG, S2HG, S3HG
    • A panel with all relevant VGAP parameters
      • S1VG, S2VG, S3VG, S3Block (see POLREF vgap opi for example)
    • A panel with all relevant "important" beamline parameters
      • (Display name: PARAM NAME)
      • Theta: THETA
      • Polariser Angle: SMANGLE
      • Polariser Height: SMOFFSET
      • Polariser Status: SMINBEAM
    • A panel with all relevant sample stack parameters
      • (Display name: PARAM NAME)
      • Height: SAMPOFFSET
      • Height 2: SAMPHEIGHT
      • Trans: SAMPTRANS
      • Phi: SAMPPHI
      • Psi: SAMPPSI
      • Chi: SAMPCHI
  • These OPIs are loaded by the reflectometry front panel if (and only if) the reflectometry config sets the OPI constant to OFFSPEC

Extra Information

Copy one of the existing instrument OPI folders, e.g. .../resources/reflectometry/INTER/, rename the folder to OFFSPEC and edit the OPIs to show the appropriate parameters

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants