WISH ORC: Fix unit tests and tidy up logic

[rerpha]

After coming back to the WISH ORC code while fixing the unit tests I realised that some logic was off (which was causing them to fail) - This logic isn't super important as it will still sweep at the correct velocity and give the steps readback meaning it's still collimating the beam correctly. The most important part of the WISH ORC is that it doesn't block the beam port - we fixed this after the uservar teething issues.

I also realised there were some variables which are actually mechanically bound to the WISH collimator such as radius etc. which we could bin off PVs for to simplify the code.

IMPORTANT: This needs to be tested on the device and verified against the Labview VI before it gets merged in, I don't want to break the collimator again....

[rerpha]

• Motorextensions: fix logic in wish ORC calcs EPICS-motorExtensions#44
• IOC tests: fixing wish orc tests - removing redundant radius etc. sets as they a… EPICS-IOC_Test_Framework#543

I have removed some unneeded PVs for things that are set as macros in OscillatingCollimator.cmd on db load as they will never change during operation of the ORC and even if they did it's just a case of changing them in the .cmd file.

This needs to be tested on our test Galil first before we even consider going near WISH with it.

[rerpha]

Numbers look correct now so think i just want to test on the testbed galil + the real thing (shutdown?) to make sure it definitely still moves etc.

[rerpha]

Moving off project board as awaiting

[rerpha]

let happy for me to test so pulling back in progress

[rerpha]

tested on LET, all working, just waiting to hear back from WISH

[rerpha]

Working on WISH as well. I am going to be a bit cheeky and merge this as the ioc tests cover the VI logic and the rest can only be (and has been) confimed on the real ORCs with a camera on a stick in the sample position