Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WISH: discussion with JN about automatic needle valve #6695

Closed
rerpha opened this issue Aug 3, 2021 · 4 comments
Closed

WISH: discussion with JN about automatic needle valve #6695

rerpha opened this issue Aug 3, 2021 · 4 comments
Assignees
Labels
1 no_release_notes Tickets that do not need release notes, use sparingly!

Comments

@rerpha
Copy link
Contributor

rerpha commented Aug 3, 2021

As a WISH (and possibly other instruments) instrument scientist I would like to control an automatic needle valve. This is a new in-house designed device which we aren't sure how to control yet so a discussion with JN needs to happen before we try and write an IOC for it.

Acceptance criteria

  • Discussion is had to find out more information on the new device
  • Device and how to control it is documented on the dev wiki
  • Ticket is created for the IOC and OPI to control it
@KathrynBaker
Copy link
Member

If this is the latest iteration then the valve is controlled via a Eurotherm and requires nothing special, if we do need to control the extended aspects that was the trigger for #4240, as those controls are outside of the existing memory space.
However, there is a project for a cryostat controller, which will be driven via a Beckhoff system, that is not yet at a stage for us to do anything with it, and the interactions should stay as standard Beckhoff for us (it's what I'm pushing for), which would mean limited interactions - this is also longer term.

@DominicOram
Copy link
Contributor

Consider whether we need SECI support for this too if they need to switch back and forth

@davidkeymer davidkeymer added the 1 label Aug 26, 2021
@github-actions github-actions bot removed the proposal label Aug 26, 2021
@KathrynBaker KathrynBaker added this to the SPRINT_2021_08_26 milestone Aug 26, 2021
@KathrynBaker KathrynBaker self-assigned this Sep 16, 2021
@KathrynBaker
Copy link
Member

When the automatic needle valve came up in a discussion for another instrument, I asked after this one.

This is the Eurotherm version with extra commands in Modbus. WISH will want access to some of those extra settings.

The commands available will be:
Switch between Auto and Manual Mode
In Auto mode, a temperature can be set
In Manual mode, a flow can be set

JN will confirm with me the values that can be read.

As such. #4240 will handle the IOC, and has been proposed for sprint 2021_09_23. #6777 has been created to handle the interface for this work.

@KathrynBaker KathrynBaker added review and removed ready labels Sep 16, 2021
@rerpha rerpha added under review no_release_notes Tickets that do not need release notes, use sparingly! labels Sep 16, 2021
@rerpha
Copy link
Contributor Author

rerpha commented Sep 16, 2021

Great, thanks, have updated https://github.com/ISISComputingGroup/IBEX/wiki/WISH-Instrument-Details linking to this ticket and the others created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 no_release_notes Tickets that do not need release notes, use sparingly!
Projects
None yet
Development

No branches or pull requests

4 participants