Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRPD: In-Situ DSC #4987

Closed
KathrynBaker opened this issue Nov 28, 2019 · 12 comments
Closed

HRPD: In-Situ DSC #4987

KathrynBaker opened this issue Nov 28, 2019 · 12 comments

Comments

@KathrynBaker
Copy link
Member

KathrynBaker commented Nov 28, 2019

As a user of the scientific program on HRPD I want to be able to conduct in-situ calorimetry within IBEX.

Acceptance Criteria

  1. There is a component on HRPD (or that could be copied there during the next opportunity) that contains the appropriate blocks for calorimetry
  2. There are PVs available relating to the differential values
  3. There is an OPI as described in the comments

Notes

  1. From an experiment controls perspective, this is made of two devices: a Lakeshore 336 and a 3 unit Eurotherm crate
  2. The required blocks from the Eurotherm are: heater set point * 4, heater ramp rate * 4, RhFe sensor * 2
  3. The required blocks from the Lakeshore 336 are: CernOx sensor * 4
  4. The differential pairs are as follows: CernOx 1, CernOx2, CernOx 1, CernOx 3, CernOx 2, CernOx 4, and CernOx 3, CernOx 4. These should probably be somewhat variable, e.g. forcing CernOx 1 - CernOx 2 could be limiting. This might be an opportunity to use some of the recently incorporated INP/OUTP field options
  5. The Eurotherm conversion to temperature will be undertaken as a standard Eurotherm in IBEX with RhFe calibration files, as such links to the associated Eurotherm OPI from the OPI for this should be considered
  6. The most basic requirement for this is the sub-config with blocks
  7. The desired version includes the differentials and an OPI with a plot of a selectable sensor/differential
  8. There is a need in the longer term for offline use which would be covered by HRPD: Purchase & prepare PC to host HRPD_SETUP  #4994
@KathrynBaker
Copy link
Member Author

KathrynBaker commented Nov 29, 2019

A suggestion for the OPI - this needs to be verified with the HRPD scientists:

image

This would be the bare minimum, a plot of a selected sensor or differential is also needed, but this can at least be initially a log plotter window instead. If that is the case a future ticket should be created to add a plotting window in the future.

@KathrynBaker
Copy link
Member Author

Original text of ticket:

This is a placeholder ticket to ensure that this is prioritised

There is a meeting on 29/11 which will be the final design review for the mechanical side of the project, the information currently known has been recorded on https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/In-Situ-DSC

Tickets and corrections will be made after the meeting tomorrow. At present, the aim is to test this at the end of January so this is the time to undertake the work. It is likely to be limited to minor db work and config setups based on the interim review

@KathrynBaker KathrynBaker changed the title In-Situ DSC HRPD: In-Situ DSC Nov 29, 2019
@Tom-Willemsen Tom-Willemsen added the 5 label Dec 3, 2019
@KathrynBaker
Copy link
Member Author

OPI with a graph suggestion:
image

@kjwoodsISIS kjwoodsISIS added bucket proposals that didn't make into the sprint and removed proposal labels Dec 5, 2019
@KathrynBaker
Copy link
Member Author

Latest update for the custom parts delivery is 20/3/20 - towards the end of cycle 2019/04

@kjwoodsISIS kjwoodsISIS added bucket proposals that didn't make into the sprint and removed bucket proposals that didn't make into the sprint proposal labels Jan 9, 2020
@kjwoodsISIS kjwoodsISIS removed the bucket proposals that didn't make into the sprint label Feb 6, 2020
@KathrynBaker
Copy link
Member Author

Needed for offline tests in January 2021

@rerpha
Copy link
Contributor

rerpha commented Dec 8, 2020

  • Does the config need to be merged as part of this ticket or does a separate task need to be created for it for afterwards?

    • there seems to be a lot of rcptt configs that need to be cleaned up as they are failing against the schema
    • the hrpd config seems to also be failing against the schema
  • these are probably linked to DETMON: Enable read-only IOC monitoring #5069 not being merged yet?

  • I'm not sure from the acceptance criteria what this means or if this solution has covered it:

    These should probably be somewhat variable, e.g. forcing CernOx 1 - CernOx 2 could be limiting. This might be an opportunity to use some of the recently incorporated INP/OUTP field options

  • We should add somewhere in the documentation that if you change the name of any of those blocks you'll need to update the db file too

  • Is it required that multiple plots are required at the same time? from Kathryn's graph it looks that way? currently you can only plot 1, if so i guess "show" tickboxes for each would be nice

  • If it is only required to draw a single plot, we should use local pvs instead of server-side pvs as even if an OPI is not stored on the server changing which PVs are plotted will do it for any OPIs that are in use. This means that it could change what scientists are seeing if a developer comes along and changes which sensor to plot. You can find these in the BOY examples using the loc:// prefix

Could you stick this in release notes as well please?

@JamesKingWork
Copy link
Contributor

JamesKingWork commented Dec 9, 2020

  • I think the config merge can be done as part of this ticket, once it's approved
    • Yes we don't want to merge anything from configs or components except the in_situ_dsc component (and the custom_records.db). I have tidied it up a bit now, but we will still need to be aware when merging.
    • Which hrpd config is failing?
  • I don't believe the DETMON issues are related to this ticket, unless I'm missing something?
  • I am also not sure of that acceptance criteria, I will discuss it with @KathrynBaker
  • I think I should actually not use block names in the custom_records.db and OPI, I will use macros to decide on the lakeshore and eurotherm to use
  • I don't believe multiple plots are required at the same time @KathrynBaker may know more though
  • I will have a look at changing this

@rerpha
Copy link
Contributor

rerpha commented Dec 9, 2020

I think all the configs were failing, @DominicOram do you remember what they were failing on?

@DominicOram
Copy link
Contributor

DominicOram commented Dec 9, 2020

The configs are failing because they contain the configuresBlockGWAndArchiver tag, which is not on the schema merged into master. That's why they relate to the DETMON ticket.

@JamesKingWork
Copy link
Contributor

Ok I did miss that, I clearly have a branch checked out that shouldn't be, good spot

@JamesKingWork
Copy link
Contributor

  • Multiple plots are now possible with tick boxes
  • It has been confirmed that the calc record of custom_records.db is sufficient, and we can generalise later if need be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants