Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make error if sh.exe in PATH #4201

Closed
FreddieAkeroyd opened this issue Mar 26, 2019 · 3 comments
Closed

build: make error if sh.exe in PATH #4201

FreddieAkeroyd opened this issue Mar 26, 2019 · 3 comments
Assignees
Labels

Comments

@FreddieAkeroyd
Copy link
Member

If sh.exe is in the windows PATH then make will fail at some point. This usually happens if the Git "bin" rather than "cmd" directory is added to PATH. Fix if possible.

@FreddieAkeroyd FreddieAkeroyd self-assigned this Mar 26, 2019
@FreddieAkeroyd
Copy link
Member Author

This seems to happen in Makefiles using "echo", so quite a bit builds, usually fails makeing runIOC.bat

@FreddieAkeroyd
Copy link
Member Author

Setting SHELL and MAKESHELL from the external environment does not help. The only workaround was to set SHELL = cmd inside a Makefile itself

@FreddieAkeroyd
Copy link
Member Author

To test:

Open CMD window in an iocBoot directory
Set "PATH=c:\program files\git\bin;%PATH%"
make clean uninstall && make

check it fails

merge patch and repeat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants