Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E4: load and save instrument-specific layout positions #3503

Closed
Tom-Willemsen opened this issue Sep 5, 2018 · 5 comments
Closed

E4: load and save instrument-specific layout positions #3503

Tom-Willemsen opened this issue Sep 5, 2018 · 5 comments
Assignees
Labels
2 Needs pair review Pull request is large or complicated and needs reviewing by a pair of developers re-requested Issue that has been requested again by a user. rework wontfix

Comments

@Tom-Willemsen
Copy link
Contributor

As a scientist, I would like to make the most of the fact that windows in E4 can be moved and resized. I would like to be able to define my instrument's default layout and save it. When I press the reset layout button it should bring back my instrument's default layout rather than the generic layout.

This has been asked for by several scientists (independently) at the E4/nicos demo sessions

@John-Holt-Tessella John-Holt-Tessella added re-requested Issue that has been requested again by a user. 1 labels Sep 20, 2018
@kjwoodsISIS kjwoodsISIS added this to the SPRINT_2018_09_27 milestone Sep 27, 2018
@Tom-Willemsen
Copy link
Contributor Author

Note: the scope of this ticket is just to save/reset a modified perspective layout, not to open new views in a perspective (that will be covered in #852 )

@John-Holt-Tessella John-Holt-Tessella changed the title E4: load and save instrument-specific layout E4: load and save instrument-specific layout positions Sep 27, 2018
@John-Holt-Tessella John-Holt-Tessella added 2 and removed 1 labels Sep 27, 2018
@Tom-Willemsen Tom-Willemsen self-assigned this Sep 27, 2018
@Tom-Willemsen
Copy link
Contributor Author

Tom-Willemsen commented Dec 17, 2018

I tried creating a squish test for this, but I couldn't figure out how to make squish click and drag without just relying on pixel offsets (which would be too brittle for the test to be reliable). I will add a manual test instead.

Note that this ticket used some of the work from #3506 as I needed a later version of eclipse, so ideally that ticket should be reviewed first (though this should not block the review of this ticket).

@Tom-Willemsen Tom-Willemsen added review Needs pair review Pull request is large or complicated and needs reviewing by a pair of developers and removed in progress labels Dec 17, 2018
@DominicOram
Copy link
Contributor

At first glance there are a few things that think this needs:

  • The perspective should be able to be reloaded without restarting the GUI
  • It would be good if the user could be told when the layout no longer matches the saved layout
  • Rather than try and upgrade layouts ourselves can we just tell the user that something is out of date and they will need to reload their perspective?

@Tom-Willemsen
Copy link
Contributor Author

As part of the review it's been decided to add the acceptance criteria:

  • I must be able to reload the saved layout without restarting the user interface

Unfortunately this means that this ticket is no longer technically feasible. I will document what's been done and close this ticket as a wontfix

@DominicOram
Copy link
Contributor

DominicOram commented Feb 19, 2019

After discussion the 1st criteria above would increase the time required for this ticket to make it unrealistic. Instead:

  • Make perspective layouts persist between restarts as part of this ticket
  • Document why this is so hard and everything that we have learnt in doing this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Needs pair review Pull request is large or complicated and needs reviewing by a pair of developers re-requested Issue that has been requested again by a user. rework wontfix
Projects
None yet
Development

No branches or pull requests

5 participants