Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asyn: add a "break on every write" option. #2768

Closed
Tom-Willemsen opened this issue Nov 10, 2017 · 2 comments
Closed

Asyn: add a "break on every write" option. #2768

Tom-Willemsen opened this issue Nov 10, 2017 · 2 comments
Assignees
Labels

Comments

@Tom-Willemsen
Copy link
Contributor

A serial break is not a series of characters but a fundamental "thing" you can do to a serial line.

This is required for ticket #2397 (fermi chopper).

Plan is to implement an option in the asyn driver that sends a serial break on the end of every message.

@FreddieAkeroyd
Copy link
Member

  • Added a "break" option to asynSetOption - specify break length in milliseconds
  • A break will be asserted after every write

To test:

  • if kit requiring a serial break is not available, try it on existing equipment to see what happens
  • enable ASYN_TRACE - you should see the words "with BREAK" displayed when number of bytes written is printed
  • you might be able to see a break with a serial port sniffer

@Tom-Willemsen
Copy link
Contributor Author

Tested by:

  • Connected to eurotherm without asyn break option - behaviour was unchanged
  • Connected to eurotherm with new asyn break option - things started timing out indicating that something was happening differently.
  • Enabled asyn trace and the new message was correctly printed ("with BREAK")
  • We don't have access to a device that requires serial breaks so I can't test that it works 100% correctly but I've reviewed the code and it looks sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants