Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance branding configuration (& refactor) #7656

Open
poikilotherm opened this issue Mar 5, 2021 · 0 comments
Open

Enhance branding configuration (& refactor) #7656

poikilotherm opened this issue Mar 5, 2021 · 0 comments

Comments

@poikilotherm
Copy link
Contributor

poikilotherm commented Mar 5, 2021 •
edited
Loading

Relates to #7649 and #7424

Currently, BrandingUtil does not do much more than handing back what you gave it. #3611 and #2710 where about options to override things.

So let's create new MPCONFIG variables:

  1. dataverse.branding.installation.name, defaulting to the root Dataverse collection name
  2. dataverse.branding.support.name, defaulting to root Dataverse collection name + contact.support bundle string as is now
  3. dataverse.branding.support.mail, defaulting to dataverse.mail.system.from introduced for Move Java Mail configuration to application #7424

These can be either injected via CDI or retrieved programmatically via Config.getValue().

Easiest way to go IMHO: add a LookupConfigSource that has access to the necessary database services and might be used for other stuff down the road.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@poikilotherm