Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make download all files feature more prominent #6118

Closed
philippconzett opened this issue Aug 26, 2019 · 5 comments · Fixed by #7047
Closed

Make download all files feature more prominent #6118

philippconzett opened this issue Aug 26, 2019 · 5 comments · Fixed by #7047
Milestone

Comments

@philippconzett
Copy link
Contributor

As a user / file downloader I'd like to have the download all files feature to be more prominent. Currently, this option only appears after ticking the box "1 to X Files of Y Files" on the top of the file table. A possible solution would be to describe the selection boxes more explicitly and have two selection boxes, one box to select all the files in the file table currently displayed on the page, and another selection box to select all the files in the dataset; see the following illustration:

image

For datasets with less than the minimal number of displayed files on one page (10 files?) the two selection boxes would obviously select the same amount of files, i.e. all files in the dataset.

@TaniaSchlatter
Copy link
Member

Thanks for opening the issue and including the mockup, @philippconzett. I agree that what you propose is more helpful for people who want to download all files, when there are more than 10 in a dataset.

@mheppler
Copy link
Contributor

Discussed this issue with the team, to get a download link displayed in the dropdown menu for the new Access Dataset btn at the top of the dataset pg, included in the new UI changes in issue #6684. This will be more prominent and simpler than adding more checkboxes. That said, improvements to the file table can be included, such as the checkbox selection functionality can be improve by describing the selection boxes more explicitly, as suggested (and also mocked up in #6605).

Here is an outline of the new feature:

QUESTIONS?

@pdurbin pdurbin self-assigned this Jun 29, 2020
pdurbin added a commit that referenced this issue Jul 1, 2020
@pdurbin pdurbin removed their assignment Jul 2, 2020
pdurbin added a commit that referenced this issue Jul 2, 2020
pdurbin added a commit that referenced this issue Jul 7, 2020
pdurbin added a commit that referenced this issue Jul 16, 2020
Also, revert changes to GetDatasetStorageSizeCommand
and DatasetServiceBean since we won't be using them.
pdurbin added a commit that referenced this issue Jul 16, 2020
@bikramj
Copy link
Contributor

bikramj commented Dec 9, 2020

Hi @pdurbin,

we are having a problem with the function getDownloadSize in file dataverse/dataset/DatasetUtil.java which was linked to this issue.

we have some old files in datatable table with originalfilesize is null, this function is failing with exception when it gets null value and interface get 500 Internal server error.

@djbrooke
Copy link
Contributor

djbrooke commented Dec 9, 2020

Hi @bikramj - I believe we added this API endpoint to help out with these cases:

https://guides.dataverse.org/en/5.1/api/native-api.html#datafile-integrity

We had some text about this in the 4.10 release notes, step 9 in the direction:

https://github.com/IQSS/dataverse/releases/tag/v4.10

Congratulations, it means your installation is one of the older ones! 🥳 Hope this does the trick. If not, please feel free to open up a new issue and we can work with you on it.

@bikramj
Copy link
Contributor

bikramj commented Dec 9, 2020

Thank you for the quick response @djbrooke, we just found same link 15minutes ago and it will do the magic. :)

And thank you again, our installation is from 2013ish DVN3 times :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants